search

tarioch / eveapi-fetcher-bundle

EVE Online API Fetcher Symfony 2 Bundle
MIT License
3 stars 1 forks source link

Fixed possible failures when importing data #14

Closed tony-stark-eth closed 8 years ago

tony-stark-eth commented 8 years ago

This was necessary for me in order to get a full api key running.

tarioch commented 8 years ago

Thanks for this, could you have a look at the scrutinizer issue?

https://scrutinizer-ci.com/g/tarioch/eveapi-fetcher-bundle/inspections/0d8aded8-cc2d-4650-88d4-594cd824bbba/issues/files/Entity/CharWalletJournal.php?status=new&orderField=path&order=asc&honorSelectedPaths=0

tony-stark-eth commented 8 years ago

Well the problem is, that taxReceiverID always should be an integer, but sometimes it occurs to be an empty string, so this is intended.

tarioch commented 8 years ago

Makes sense, you mind changing https://github.com/tarioch/eveapi-fetcher-bundle/blob/master/Component/EveApi/Char/WalletJournalUpdater.php instead of the entity? Should be cleaner and would avoid the problem. I prefer to deal with the API quirks in the api updaters instead of directly the entities.

tony-stark-eth commented 8 years ago

Yes you are right. I applied the changes :)