search

tariqbuilds / linux-dash

A beautiful web dashboard for Linux
https://afaqurk.github.io/linux-dash/
MIT License
10.43k stars 1.2k forks source link

Add support for env port #388

Closed stephenlacy closed 8 years ago

stephenlacy commented 8 years ago

Hey,

Wanted to see if this would be accepted before I submitted a PR.

Would you consider adding an env option for setting the port instead of editing both go and node's config file for the port, with default to 80? Most of the systems I run and want linux-dash to run have an nginx server on port 80.

Node example: $ PORT=3000 npm start

server.listen(process.env.PORT || 80);

Similar effect for Go.

tariqbuilds commented 8 years ago

Awesome idea. Relying on the environment is a great idea and will make Linux Dash easier to configure. As long as we use a very specific, non-common prefix on all env variables, I think it should work very well. Ex: LINUX_DASH_HTTP_PORT rather than PORT.

I would suggest making the PR against the v2.0 branch (https://github.com/afaqurk/linux-dash/tree/v2.0) instead of master. It is expected to be released soon.

If you need some guidance on the v2.0 branch, check the docs: https://linux-dash.github.io/

Thanks for bringing this up.