search

tarkah / grout

Simple tiling window manager for Windows
MIT License
202 stars 8 forks source link

Refactoring. #36

Closed DiXN closed 4 years ago

DiXN commented 4 years ago

I did some basic refactoring.

While doing so I noticed that you implemented most components solely with the WinAPI. Is there a reason why you wouldn't use https://github.com/qdot/systray-rs for the tray for example? Crates that offer abstraction over the native API would increase readability in my opinion, in case they support the same features of course.

tarkah commented 4 years ago

No reason in particular, just was comfortable with using winapi by the time I implemented the sys tray.

Thanks! I'll take a closer look at this tomorrow.

tarkah commented 4 years ago

@DiXN I've reverted the expect and will add in proper error handling into a new PR. Thanks for this!