search

tarkah / tickrs

Realtime ticker data in your terminal 📈
MIT License
1.17k stars 58 forks source link

Some symbols always low of zero, resulting in wrong y-axis scaling used #22

Closed daniel-j-h closed 3 years ago

daniel-j-h commented 3 years ago

Hey hey :wave: it looks like for some symbols (TSLA in the case below) the low is at zero for all time ranges, resulting in plots like the 1D plot to be hard to impossible to read and interpret since we're not "zooming in" on the daily variation.

Here is a screenshot of what I mean. Is this the API sometimes just reporting zero as low? Can we do something in this case?

tsla

tarkah commented 3 years ago

Thanks for reporting the issue! I'll look into this today.

tarkah commented 3 years ago

So I'm calculating the min / max plot points from the data-set to set the y-axis bounds. What appears to be causing your problem is that your current market price is 0, which is causing the min to be 0.

It appears you are having lots of issues fetching data from the API.... you must have a slow / bad connection to wherever the yahoo api servers are located. Along with #23 , I probably should hold off on rendering anything related to the widget until I can guarantee all 3 initial API calls (graph data, current market price, company info) are completed. And as you mentioned, instead put some sort of loading indicator.

tarkah commented 3 years ago

I'm going to close this with merging #29