search

tarkah / tickrs

Realtime ticker data in your terminal 📈
MIT License
1.17k stars 58 forks source link

Sometimes no data points shown except high / low #23

Closed daniel-j-h closed 3 years ago

daniel-j-h commented 3 years ago

Hey hey :wave: It seems like sometimes we can not get any data points other than high / low.

Is this caused by the API? Can this be solved with retries? Should we show a spinner :recycle: or something indicating that we're in the process of fetching the data?

nodata

tarkah commented 3 years ago

Yeah what's probably happening is it's grabbing the current market price from the API, but can't grab the graph data. Which is why you only see the 1 dot.

Does the graph data eventually show up? This is probably caused when I deserialize the json response. I'm probably expecting a field that doesn't exist in the response, so I need to make that field optional since it doesn't always come across. I've noticed this API likes randomly omitting certain fields on rare occasion.

daniel-j-h commented 3 years ago

Yes, the graph eventually shows up when restarting / reloading. Not entirely sure when this triggers, seems random to me.

tarkah commented 3 years ago

As I mentioned in #22, I think this all boils down to network issues fetching against the API. I can see this same view for a micro second before the data loads in from the API. So on top of holding off the render until all data is grabbed and showing a loading indicator, poor connections like yours need some sort of API request retry.

tarkah commented 3 years ago

I'm going to close this with merging #29