search

tarkah / tickrs

Realtime ticker data in your terminal 📈
MIT License
1.17k stars 58 forks source link

Crash if invalid ticker is given #4

Closed senden9 closed 3 years ago

senden9 commented 3 years ago

How to reproduce:

  1. Start tickrs
  2. Enter * into the "Add Ricker" proms
  3. Crash (see image) image

Suggestion: Either add character checks at the input or escape the input before create the query URL

tarkah commented 3 years ago

Yeah, I'm using a library to parse the final Uri from a string and was just unwrapping the result. I'll add some error handling here, thanks!

tarkah commented 3 years ago

Fixed in newest release, new binaries will be published shortly

https://github.com/tarkah/tickrs/releases/tag/v0.3.3