gray out options toggle on crypto

tarkah / tickrs

Realtime ticker data in your terminal 📈

MIT License

1.16k stars 58 forks source link

gray out options toggle on crypto #94

Open miraclx opened 3 years ago

miraclx commented 3 years ago

Inspired by #93's behaviour with the Volumes 'v' item in the toggles, this relaxes #37 and better resolves #49.

tarkah commented 3 years ago

Haha you've read my mind, love it

tarkah commented 3 years ago

We should do the same for Pre Post 'p' in non-1D timeframes, can you just layer that into this PR?

miraclx commented 3 years ago

Absolutely, I'm on it!

miraclx commented 3 years ago

I went into working on this thinking Pre Post 'p' didn't do anything for all non-1D timeframes. But I just realized that wasn't the case.

What's the constraint I need to check for to disable this?

Is it crypto specific?
Or is it just non-1D timeframes? (I didn't notice any changes with pre-post, 1D timeframe for any crypto I tested with)

I guess I'm just asking, does pre-post work for crypto at all?

tarkah commented 3 years ago

Yeah, pre / post isn't applicable for ~Options~ Crypto because they trade 24/7. So you can have it disabled completely for options, then just non-1D for everything else.

miraclx commented 3 years ago

Options? Do you mean crypto?

And for "everything" else, I actually notice some changes on non-crypto symbols when in non-1D time frames.

To be clear, are you saying pre-post should only work for non-crypto symbols in the 1D timeframe, because if that's the case then that's not what's happening.

tarkah commented 3 years ago

Options? Do you mean crypto?

And for "everything" else, I actually notice some changes on non-crypto symbols when in non-1D time frames.

To be clear, are you saying pre-post should only work for non-crypto symbols in the 1D timeframe, because if that's the case then that's not what's happening.

Yes sorry, crypto. Yeah, that's what should be happening. Can you give me some examples where pre / post is changing things for non-1D time frames or crypto?

miraclx commented 3 years ago

It's not changing things for crypto but for everything else:

pre/post disabled	pre/post enabled

The values change and the graph changes slightly too at the rightmost edge

tarkah commented 3 years ago

Ahh right, because I use the Post Market price as the last datapoint when it's toggle on vs Regular Market price when it's off, which alters the last datapoint on all the timeframes. I can easily fix that, I don't really think it makes sense to show the post-market price on the other time frames. What do you think?

miraclx commented 3 years ago

Yeah, it doesn't strike me as a useful metric outside of that. It's only really usable in the 1D timeframe.

So with this PR, to clarify, I'll be graying out pre-post entirely for crypto and only on non-1D timeframes for others.

I should probably wait for that fix so I can rebase and push.

tarkah commented 3 years ago

Sounds like a plan. I'll try to tackle that sometime tomorrow.