search

tarlog / tarlog-plugins

Automatically exported from code.google.com/p/tarlog-plugins
10 stars 5 forks source link

No DLTK support #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Install PHP (or any DLTK [Dynamic Language Toolkit]) plugin
2. No option to Open Command Prompt nor Windows Explorer

What version of the product are you using? On what operating system?
I'm using version 1.4.0

I attached a patch that I created to add DLTK support and seems to work 
alright. Not sure if you want to add it your plugin since it adds a dependency. 
But thought I'd let you know if if you were interested. The patch is to be 
applied to the project.

Original issue reported on code.google.com by sanjayginde on 10 Jun 2010 at 7:16

Attachments:

GoogleCodeExporter commented 9 years ago 
So I worked on the plugin patch a bit more and I think I eliminated a need for 
the DLTK dependency. I flag that dependency as optional and abstracted the 
class type checking to utilize a String based approach. I think it might be 
good to do this for the Java dependency as well so the plugin could work 
without that feature.

Original comment by sanjayginde on 10 Jun 2010 at 10:00

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for your input.
I'll try to take a look at the patches at the beginner of the next week.

Thanks again!

Original comment by tarlog on 11 Jun 2010 at 10:02

GoogleCodeExporter commented 9 years ago 
Just wanted to notify that I didn't forget about this issue.
I'm quite busy with other projects these days, but I'm trying to free some time.

Original comment by tarlog on 23 Jun 2010 at 5:52

GoogleCodeExporter commented 9 years ago 
Thanks for a patches, but I don't want to add DLTK dependencies to the plugin.
Btw, the plugin works from Navigator even at DLTK environments, but not from 
PHP Explorer.
Sorry...

Original comment by tarlog on 27 Jun 2010 at 6:46