tarm / serial

BSD 3-Clause "New" or "Revised" License
1.6k stars 453 forks source link

Remove unused references to syscall.Termios.{Ispeed,Ospeed} #74

Closed nocko closed 6 years ago

nocko commented 6 years ago

This (in combination with #73 ) fixes build on mips and mipsle #59. These struct members aren't referenced anywhere else in the code.

tarm commented 6 years ago

Thanks for the PR!

I'm not sure that works though. &t is passed to the syscall (line 115), so this will change the arguments to the syscall.

I think you may need to make a different .go file and add build constraints for mips and mipsle.

tarm commented 6 years ago

This works for me from master:

$ GOARCH=mips GOOS=linux go install . $ GOARCH=mipsle GOOS=linux go install .

What do you get instead?

nocko commented 6 years ago

I can no longer replicate my build issue.