Return an error when requested ReadTimeout is larger than supported max of 25.5s

tarm / serial

BSD 3-Clause "New" or "Revised" License

1.62k stars 452 forks source link

Return an error when requested ReadTimeout is larger than supported max of 25.5s #98

Open jaapz opened 5 years ago

jaapz commented 5 years ago

Took me a while of debugging to find out that timeouts given to ReadTimeout never go longer than 25.5 s. I work with a modem that can take 3 minutes to respond to certain commands.

Would by nice to have the init error out when a timeout higher than 25.5s is given, instead of silently limiting the min/max values of ReadTimeout.

benma commented 4 years ago

I ran into the same. It would also be great to document why this limit exists in the first place. Could it be increased?