search

tarmolov / git-hooks-js

A tool to manage and run project git hooks
167 stars 30 forks source link

Use a bash script for the template hook #19

Closed mblakele closed 8 years ago

mblakele commented 8 years ago

This allows use with GUI tools such as IDEs, which sometimes can't find the node command in the environment PATH. This implementation assumes nvm, and expects node to be available through $HOME/.nvm.

This approach might not suit every environment. It might make sense to have an install-time switch between node-based hooks and bash-based hooks, maybe using environment variables.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.5%) to 93.636% when pulling 1cfc74e0e50eff7d4b509050c59c5d528f70060f on mblakele:bash-hooks into b072ec8c12277b8eab89f1872476bfc3e720d636 on tarmolov:master.

tarmolov commented 8 years ago

I think it's not a good idea to add some environment specific code to the tool. Also I prefer to keep git-hook-js written in javascript only.

If you create an IDE wrapper which uses git-hooks-js under the hood, I'll add the link to Readme with the great pleasure.