Pass standard input through to all hooks

tarmolov / git-hooks-js

A tool to manage and run project git hooks

167 stars 30 forks source link

Pass standard input through to all hooks #21

Closed getsnoopy closed 7 years ago

getsnoopy commented 8 years ago

Some git hooks can be passed additional information through standard input (e.g., the pre-push hook), so this commit handles that properly. Since stream data can be consumed only once but multiple hooks may need to use it, capture the stream data once and pipe it to each child process individually.

coveralls commented 8 years ago

Coverage decreased (-0.9%) to 94.286% when pulling 8146487908b3fcbe3ae6e193810d4657724098f3 on getsnoopy:master into 166b5694a83bc73a4ea63e017cfdb380af5f50c1 on tarmolov:master.

tarmolov commented 8 years ago

https://github.com/tarmolov/git-hooks-js/blob/master/CONTRIBUTING.md#pull-requests-and-code-contributions

coveralls commented 8 years ago

Coverage increased (+0.09%) to 95.238% when pulling 8ea4514a9dc48e4662053d683f8ef8442a846f2d on getsnoopy:master into 166b5694a83bc73a4ea63e017cfdb380af5f50c1 on tarmolov:master.

tarmolov commented 8 years ago

It's better to add an extra test to check that input is passed properly to the hook.