Allow execution on Windows

tarmolov / git-hooks-js

A tool to manage and run project git hooks

167 stars 30 forks source link

Allow execution on Windows #29

Closed codebling closed 7 years ago

codebling commented 7 years ago

There are 2 issues blocking windows execution: verifying execution bit and launching Unix-style scripts. This PR resolves both.

codebling commented 7 years ago

Didn't run tests like a noob. Fixed code style, will make tests Windows-friendly tomorrow.

coveralls commented 7 years ago

Coverage decreased (-8.08%) to 87.069% when pulling 36cfce94af18bf276dcac0b06ca4427d6b8a0325 on codebling:master into 069d80a9399ebe531563e2234cc83d1abb1b8ef4 on tarmolov:master.

coveralls commented 7 years ago

Coverage decreased (-8.08%) to 87.069% when pulling 36cfce94af18bf276dcac0b06ca4427d6b8a0325 on codebling:master into 069d80a9399ebe531563e2234cc83d1abb1b8ef4 on tarmolov:master.

codebling commented 7 years ago

Fixes #10

coveralls commented 7 years ago

Coverage decreased (-8.6%) to 86.508% when pulling 1c4b3e6d3e86585931165a6c7f71f2e9fe6f569a on codebling:master into 069d80a9399ebe531563e2234cc83d1abb1b8ef4 on tarmolov:master.

codebling commented 7 years ago

Because I created this PR from master, the changes in this PR now include the changes from #31. To only merge the Windows changes, pull from branch 'windows' instead. To merge #31 and windows, merge this PR.

tarmolov commented 7 years ago

Sorry for the huge delay with decision about Windows support. I decided keep support only for Unix and macOS. I can guarantee expected behaviour only on this platforms.

And again I want to say sorry about negative decision.

codebling commented 6 years ago

Anyone looking for Windows support should check out Husky. It's a very active project which allows you to set up git hooks in your package.json file. It supports OSX, linux and Windows and has support for a few other hooks which git-hooks-js does not.