search

tarmolov / git-hooks-js

A tool to manage and run project git hooks
167 stars 30 forks source link

Upgrade dev dependencies in package.json #55

Closed rjmunro closed 6 years ago

rjmunro commented 6 years ago

But stick with a 2.x.x version of JSCS as upgrading to 3.x.x broke things.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-1.01%) to 92.929% when pulling 5f45ed7167e7755d0eeb1c12d8d27be763e44e2c on rjmunro:upgrade-deps into aaf26a1364e10049e9e9bfddfb77935de5a8699c on tarmolov:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-1.01%) to 92.929% when pulling 5f45ed7167e7755d0eeb1c12d8d27be763e44e2c on rjmunro:upgrade-deps into aaf26a1364e10049e9e9bfddfb77935de5a8699c on tarmolov:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.9%) to 97.895% when pulling a09af18e60d56243e096e5ddce2f99cdbdadaca2 on rjmunro:upgrade-deps into e83af69d6c80979e8ca603417836df5a90fa16ce on tarmolov:master.

tarmolov commented 6 years ago

I think it's better to replace jsint + jscs with eslint. https://github.com/ymaps/codestyle/tree/master/packages/eslint-config-loris — here is the right base config for it.

Would you like to make this replacement in this pr?

rjmunro commented 6 years ago

@tarmolov I can look into that, yes. What do you think of dropping support for node 0.x? So we would only support node 4 and above? It means we can drop some older code and use e.g. execSync and have to worry about accessSync versus existsSync.

tarmolov commented 6 years ago

I think 4 can be dropped as well according to https://github.com/nodejs/Release#release-schedule. After this changes it's better to up git-hooks major version because we break backward compatibility.

rjmunro commented 6 years ago

I've upgraded to node v5 and removed some code only necessary on older versions. I've had a go at moving to eslint, but I've decided that should be a separate PR (#59) as I'm not sure how to fix the errors it is throwing.

It would be great if this could be merged, then I can rebase #57 and #58 and therefore fix #48. This would mean that my project would start validating even when it is a submodule, which will save me a lot of frustration.