search

tarmstrong / nbdiff

A diffing and merging tool for the IPython Notebook.
http://nbdiff.org
MIT License
212 stars 28 forks source link

Use python-Levenshtein for fuzzy string matching #175

Closed tarmstrong closed 10 years ago

tarmstrong commented 10 years ago

This introduces a new dependency, python-levenshtein to calculate string edit distances. This speeds up the fuzzy string matching used to match modified cells, but it might make it more difficult for users to install.

tarmstrong commented 10 years ago

@NightlyBuilds please test on windows. You'll have to run python setup.py develop again for the new package to be installed.

NightlyBuilds commented 10 years ago

I pulled from this branch, ran python setup.py develop, and ran both scripts make_diff.py and make_merge_conflict.py. Also called nbmerge and nbdiff in their respective folders. They both worked without issues. Just to ask looking at requirements.txt should we mention anaconda, pip_install, or easy_install as i have them on my windows and they might have been called during the setup.py?

If you require me to conduct another test on windows you can tell me.

tarmstrong commented 10 years ago

Just to ask looking at requirements.txt should we mention anaconda, pip_install, or easy_install as i have them on my windows and they might have been called during the setup.py?

Nope -- those are the packaging programs and stuff that are used to install the stuff listed in requirements.txt and setup.py. That is, we can assume that they already have those installed.