search

tarmstrong / nbdiff

A diffing and merging tool for the IPython Notebook.
http://nbdiff.org
MIT License
212 stars 28 forks source link

Use nbdiff on Mercurial repositories #228

Closed tmbb closed 10 years ago

tmbb commented 10 years ago

I tried to run nbdiff on a hg repository, which failed. From my reading of the source code, nbdiff without arguments only seems to work with a git repo. It would be useful to have it working with a hg repo, especially since the documentation says that nbmerge can be used as a merging tool in hg (I didn't try the merge tool)

bpipev commented 10 years ago

Hi, Thanks for the feedback. We know that nbdiff without arguments is not working with mercurial. I'm going to start working on that soon, so that you can use that command.

tmbb commented 10 years ago

Thanks for the reply. I have looked at the source code, but I don't know a lot about hg internals and I don't think I can write a hg adapter all by myself

bpipev commented 10 years ago

Well, I'm not very familiar with hg either, but it'll be a good learning experience :)

tmbb commented 10 years ago

I have submitted a pull request that adresses this. It uses python-hglib and requires very little aditional code.

I still haven't written any tests, but I will do so when I have the time. It has been working well for me.