search

tarnacious / text-invoice

a gem for managing invoices stored as yaml.
MIT License
1 stars 3 forks source link

Enhance configuration capabilty of text-invoice #3

Open doc75 opened 9 years ago

doc75 commented 9 years ago

Hello,

I like the simplicity of your gem and would like to be able to use it in some personal code to manage invoices. The aim is to build on top of your gem a kind of invoice manager to have a higher level of management (still in command line) with an invoice store of yaml file.

to do so, it requires some configuration capability in the following area:

  1. ability to use a custom blank invoice rather than the invoice.yaml file located in lib/text-invoice
  2. ability to translate the text output (like in summary).

I can work on this to update your gem, but before doing so I want to make sure that you are OK with this direction. The aim would be to keep current behaviour in default case.

Let me know.

tarnacious commented 9 years ago

Hi,

Thanks for your other merge request. I actually had to lookup how to bundle and run tests in Ruby, it has been a while. Your change also fixed the deprecation notices, and the colours are pretty. Thanks!

I'm glad you found the gem to your liking, I haven't done much freelancing work in a while so haven't needed it, but I am expecting that to change shortly.

I am more than happy for you to extend the functionality as you describe, for my part I would be happy to:

a) Add whatever permissive licence you like, if you don't have a preference I will just add whatever licence Ruby uses.

b) Grant you commit access to this repository (I assume this is possible)

c) Add yours and Scotts name at the end of the README or in a contributors file.

I'll await your response to make the above changes, but will make them as soon as I get your response.

Thanks.

doc75 commented 9 years ago

Thanks for your quick answer.

a) use the one you like. Usually I am using MIT license on my side, but as soon as this is a permissive licence, no issue to me.

b) Yes this is possible as I was granted access to another repository, but I did not do it myself.

c) No problem.

Other things I have in mind (if you approved them):

tarnacious commented 9 years ago

Ok, you're now a contributor and I added LICENCE and CONTRIBUTORS files.

I would prefer we didn't rename the gem as I think this is more likely to annoy someone than not following the conventions. If it was currently using uppercase letters and was actually causing issues for someone using a case-insensitive file system I would support that change. Does this seem reasonable? If you you still feel strongly about changing the name I am happy to reconsider.

Regarding other changes, I think you like the gem for the same reasons I do and trust your judgement to extend it. However if you would like to discuss proposed changes I am happy to do so here.

Cheers.