search

tarosky / http2-server-push-preload

Send Link headers for HTTP/2 server push for WordPress
11 stars 0 forks source link

Running nightly displays update notice #2

Open aaronjorbin opened 6 years ago

aaronjorbin commented 6 years ago

Not sure if this is a bug in the plugin or in an updater library, but with a master checkout, I'm getting the following notice:

screen shot 2018-03-10 at 6 01 47 pm
miya0001 commented 6 years ago

Hi @aaronjorbin Thanks for trying this. It has a updater from GitHub and please download and install http2-server-push-preload.zip from following.

https://github.com/tarosky/http2-server-push-preload/releases/tag/0.4.0

Thanks 😊

miya0001 commented 6 years ago

Ah, or you can click update now. 😄

aaronjorbin commented 6 years ago

@miya0001 So it's best to not run it directly from Github?

Thanks for building this!

miya0001 commented 6 years ago

@aaronjorbin

Version number is updated by Travis CI from nightly to ${TRAVIS_TAG} when build, because I always forget to update it. So, if people install it from master, it will have update soon. 😊

https://github.com/tarosky/http2-server-push-preload/blob/master/.travis.yml#L33

I will very very happy if you give me a feedback if you have a moment. Thanks!

kevin25 commented 6 years ago

Thank you for great plugin. Does it work with fastcgi instead of proxy?

location = / {

proxy_pass http://upstream; ... ... ... proxy_buffer_size 128k; proxy_buffers 4 256k; proxy_busy_buffers_size 256k; http2_push_preload on; }

miya0001 commented 6 years ago

Maybe yes, but I haven't tried yet.

Actually, I realized that browses can't use browser cache, because all of resources are pushed to browser immediately. I guess this solution doen't improve site speed for now...