tarpas / pytest-testmon

Selects tests affected by changed files. Executes the right tests first. Continuous test runner when used with pytest-watch.
https://testmon.org
MIT License
800 stars 54 forks source link

Allow using --testmon-noselect and --testmon-nocollect simultaneously #227

Closed GytisZ closed 8 months ago

GytisZ commented 8 months ago

Is your feature request related to a problem? Please describe. We're utilizing your project for local development and are keen to integrate testmon into our CI. However, we face a challenge when combining the --testmon-noselect and --testmon-nocollect flags. Using them together results in --notestmon due to this check.

We're trying to combine them in CI in order to preserve coverage checking while also having the checks fail as fast as possible.

Describe the solution you'd like Please enable the simultaneous use of both --testmon-noselect and --testmon-nocollect. This can be achieved by removing the aforementioned check.

Additionally, consider updating the documentation for --testmon-noselect on testmon.org. It currently omits the feature that it reorders tests.

Describe alternatives you've considered An ideal solution might involve more intuitive flag naming, like splitting --testmon-noselect into two flags: --testmon-noselect and --testmon-reorder. This would clarify the purpose of each flag and reduce potential conflicts.

Additional context

Are there guidelines on contributing to this project? While removing the check seems straightforward, the absence of tests suggests there might be other considerations. Is there a private codebase behind testmon.net?

tarpas commented 8 months ago

Thanks for suggestion. I'll still sleep on it but I think removing the check si reasonable. You're right, there is an internal codebase so yes, it's easiest I remove the line and everything else.

GytisZ commented 8 months ago

Thank you for considering this @tarpas . Just for additional context - noticed that there was a similar request in the comments under another issue: https://github.com/tarpas/pytest-testmon/issues/86#issuecomment-1704648525

tarpas commented 8 months ago

Released as v2.1.0, thanks for your input.