search

tarr11 / IntercomDotnet

Wrapper for Intercom.io API for .NET
Apache License 2.0
15 stars 14 forks source link

Changing userId to be a string instead of an integer #16

Closed EdBlankenship closed 8 years ago

EdBlankenship commented 9 years ago

UserId’s can be non-numeric with Intercom. Updating the GET method to allow for string values. Hope this helps!

mgoodfellow commented 9 years ago

Hi @EdBlankenship,

Thanks for the PR! Can you have a look at my comments? I'm away this weekend but can merge on Monday,

Thanks!

EdBlankenship commented 9 years ago

@mgoodfellow - No problem! Great suggestions. New updates coming shortly.

mgoodfellow commented 8 years ago

Hi @EdBlankenship,

Thanks for the changes, LGTM :+1:

Resolves: https://github.com/tarr11/IntercomDotnet/issues/15

I will merge this now and update the package on NuGet