search

tarrlab / physio2bids

Siemens physiological recording BIDS converter
7 stars 4 forks source link

Integration with BIDScoin #1

Open marcelzwiers opened 4 years ago

marcelzwiers commented 4 years ago

Hi Austin Marcus,

I am the author of BIDScoin, a DICOM to BIDS converter: https://github.com/Donders-Institute/bidscoin

BIDScoin doesn't convert physio data but supports plugins and I think it is quite easy to build a plugin-wrapper around your tool so that it integrates directly with BIDScoin. Are you still actively developing physio2bids and are you interested in making this possible? We could work on it together...

Cheers, Marcel

pitchaim commented 2 years ago

Hi @marcelzwiers , thanks for filing this, and sorry not to have gotten back for some time! If you haven’t already added another plugin to your project to do physio conversion, I’d be glad to help integrate. Otherwise, thanks anyway for considering!

marcelzwiers commented 2 years ago

I've been working with the phys2bids people to write a plugin, and it was almost finished but then got stalled (https://github.com/ohbm/hackathon2021/issues/12). I am surprised to see that your project is still alive, since your last commit activity here was 4 years ago. For me it makes more sense to finish the phys2bidscoin plugin instead of starting a new one, but I would be glad to help you if you would like to write a bidscoin plugin for your tool

marcelzwiers commented 2 years ago

I had another look at your code and it seems to complement my python port of the Matlab CMRR-DICOM physio converter: https://github.com/CMRR-C2P/MB/blob/master/readCMRRPhysio.py (I wrote this code as part of BIDScoin). Perhaps it would be interesting to merge the two Siemens physio converters...

marcelzwiers commented 2 years ago

Let me ping @smoia (Stefano Moia), I think he may be interested in this too

marcelzwiers commented 2 years ago

Does your code work with the new Siemens product sequence or with the old PMU unit implementation?

smoia commented 2 years ago

Hey there! I've been trying to reach out too for the same reason! @pitchaim would you be interested in porting / integrating your plugin into phys2bids? If so that'd be integrated into bidscoin as well! We've been working with other developers to integrate other solutions too, and we have an ongoing PR for GE scanners. Adding Siemens should be easier with that!

smoia commented 2 years ago

(Also we're interested in supporting everything possible)

marcelzwiers commented 2 years ago

Here's another project with similar goals, would be nice if we'd all be working on a single tool :-) https://github.com/cbinyu/bidsphysio