search

tarsil / saffier

The only ORM that you will ever need for python.
https://saffier.tarsild.io
MIT License
60 stars 4 forks source link

refactor: check that the user-defined table has 1 and only 1 primary key. #126

Closed vvanglro closed 9 months ago

vvanglro commented 9 months ago

Close #123 .

vvanglro commented 9 months ago

I will fix the test case later.

vvanglro commented 9 months ago

@tarsil Ready, It's best to squash and merge.

tarsil commented 9 months ago

@vvanglro 61 files is a very big change even if it's because of pre-commit.

I would advise you to do incremental changes, not like this. Unfortunately this is huge to merge.

Do you want to make it smaller?

vvanglro commented 9 months ago

If the changes are ok, you can just select squash merge when you merge.

I have run pre-commit locally.

tarsil commented 9 months ago

@vvanglro squashing doesn't change the number of files changed unfortunately. Also majority the files changed have nothing to do with the goal of this PR.

My advice would be to close the PR and open a smaller one only with the required changes

vvanglro commented 9 months ago

@vvanglro squashing doesn't change the number of files changed unfortunately. Also majority the files changed have nothing to do with the goal of this PR.

My advice would be to close the PR and open a smaller one only with the required changes

Test cases cannot pass ci tests without modifications. So all file modifications are relevant to this PR.

tarsil commented 9 months ago

@vvanglro where changing the .editorconfig impacts the test cases?

vvanglro commented 9 months ago

@vvanglro where changing the .editorconfig impacts the test cases?

Caused by running pre-commit locally, Added line breaks.