search

tarsqi / ttk

Tarsqi Toolkit
Apache License 2.0
25 stars 10 forks source link

Rework Evita GramChunk class #30

Closed marcverhagen closed 7 years ago

marcverhagen commented 7 years ago

This class is not well-named and keeps confusing me. It is not a chunk but it contains the features of a chunk. Maybe use ChunkFeatures or something like that (as well as subtypes AChunkFeatures, NChunkFeatures and VChunkFeatures).

GramVChunkList should also be renamed (VChunkFeaturesFactory?). This class also has the issue that it has two very different tasks: handling chunk features and generating lists of VerbChunks. The latter should be split off if possible.

marcverhagen commented 7 years ago

Done in https://github.com/tarsqi/ttk/commit/6ca005b5f32a02b41ee66686f4a007e292f7d4ec, https://github.com/tarsqi/ttk/commit/e9b9662a99f4fa3c7a1e73c5b5fd755ebed86572 and https://github.com/tarsqi/ttk/commit/59eeedda4db4ceeeec2a2bb8841a10d23b80afc2.

There happened to be no overloading issue with GramVChunkList. There were a few testing methods under the verb features that includes some chunk information, these were refactored.