tarsqi / ttk

Tarsqi Toolkit
Apache License 2.0
25 stars 10 forks source link

Failed DCT import on Timebank document #70

Closed marcverhagen closed 7 years ago

marcverhagen commented 7 years ago

You can process a Timebank document with the --dct option:

$ python tarsqi.py --dct 20170317 --source timebank data/in/Timebank/wsj_1073.xml wsj_1073.xml

But in the result the metadata show the DCT retrieved from the document, not the one handed in. This may actually be the right behavior, but that should at least be documented.

In general, the documentation in docs/notes/dct.md is a bit off. Should for example add the dct option to the table for clarification and should mention that a normalized value should be used (actually, I take that back, it is mentioned in tarsqi.py, just need to add it to the manual.

marcverhagen commented 7 years ago

So this is done, but I am leaving the issue open till two changes are made to the manual: