tarsqi / ttk

Tarsqi Toolkit
Apache License 2.0
25 stars 10 forks source link

Writing to standard output #74

Closed marcverhagen closed 5 years ago

marcverhagen commented 7 years ago

There are many occasions where TTK writes to standard output. This is not a good idea when you use the --pipe option. Printing to stdout is okay when processing a directory, but printing to stdout in standard file or pipe processing should be eliminated.

Find all those occasions and replace them with calls to the logger or write to stderr.

marcverhagen commented 7 years ago

This was fixed for a line in components/common_modules/tree.py (which contained the print statement that first alerted us to this problem).

marcverhagen commented 7 years ago

Removed writing error report to stdout in commit https://github.com/tarsqi/ttk/commit/7cc7060facc7fe20aa3c80353ccd383eb144ea1e.

marcverhagen commented 5 years ago

Checked all print statements in the code and removed the dangerous ones or replaced them with calls to the logger. Print statements were allowed on some spots:

marcverhagen commented 5 years ago

Fixed in a9662a1.