tarsqi / ttk

Tarsqi Toolkit
Apache License 2.0
25 stars 10 forks source link

Chunker and timex tags #76

Open marcverhagen opened 7 years ago

marcverhagen commented 7 years ago

There was an issue with chunks like

[for the fourth quarter ended Aug.]NG 26.

When GUTime finds Aug. 26 it does enter it into the TagRepository, but it cannot add it to TarsqiTree when later components apply, and it can therefore not be linked. It would be better to have one of the following

[for the [fourth quarter]timex3 ended [Aug. 26]timex3]NG.
for the [[fourth quarter]timex3]NG ended [[Aug. 26]timex3]NG.

Some of this was referred to in issue #75 and partially dealt with in commit https://github.com/tarsqi/ttk/commit/f6aad2724eaaf80eb19a114b22758c31364fcebd. But this may need a bit more thought. We now just completely remove those chunks and build new chunks for the timexes, but there might be more material in those chunks and we could miss some events because of that. Note that these cases do not occur in the test and regression tests.