tarsqi / ttk

Tarsqi Toolkit
Apache License 2.0
25 stars 10 forks source link

TreeTagger subprocess.Popen fails for windows #8

Closed marcverhagen closed 8 years ago

marcverhagen commented 8 years ago

The treetaggerwrapper.py script uses the following:

p = subprocess.Popen(tagcmd, shell=True, stdin=pipe, stdout=pipe, close_fds=True)

This needs to be updated for windows, which appears to require close_fds=False. This was possibly not an issue in the original script since it used os.popen2.

This fix is needed for the GUTime and merger wrappers as well.

marcverhagen commented 8 years ago

https://github.com/tarsqi/ttk/commit/c1eafd4db1a7d68d96981647eff71d6695bf4f15