search

tasdikrahman / vocabulary

[Not Maintained anymore] Python Module to get Meanings, Synonyms and what not for a given word
https://vocabulary.readthedocs.io/en/latest/
MIT License
560 stars 76 forks source link

Feature/test mocking #26

Closed tenorz007 closed 7 years ago

tenorz007 commented 7 years ago

So I was finally able to come around to mocking all external API calls. When you run the tests now, they are way much faster as they don't have to make any external calls.

PS: I also came across a few bugs in the code.

tasdikrahman commented 7 years ago

Hey @tenorz007 . Good to see you back 😄

I am not too familiar with the mocks framework. Will have to check this PR out later today/tomorrow. Any good resource to go through?

Also, I see you mentioned you found some bugs. Would be great if you could point them out for the brevity in this thread.

And again, thanks for contributing 👍

Cheers

tenorz007 commented 7 years ago

Python 2 Docs blog

tasdikrahman commented 7 years ago

@tenorz007 Going through them. Would it be ok for you to join our gitter channel. Had some questions which if put on this PR thread would spam the whole watchers list. Here is the link for the channel. https://gitter.im/prodicus/vocabulary Ping me there if you join it

Cheers!

tasdikrahman commented 7 years ago

@tenorz007 I was wondering whether we should also add some test(s) which hit the real server. I mean if the data on their end changes at some point. The parsing would break basically testing our mocked data response to what the response the API server is returning to us,

What are your thoughts on it?

tasdikrahman commented 7 years ago

Also, showing test coverage would be a great thing too if possible

tenorz007 commented 7 years ago

Yeah coverage would be a good addition, so you can actually see how much of the code is being tested.