Closed tenorz007 closed 7 years ago
Before
>>> vb.pronunciation("hippopotamus")
[{"rawType": "ahd-legacy", "raw": "hip", "seq": 0}, {"rawType": "arpabet", "raw": "HH IH2 P AH0 P AA1 T AH0 M AH0 S", "seq": 0}]
>>> vb.part_of_speech("hello")
[{"text": "interjection", "example": "greeting", "seq": 0}]
>>> vb.antonym("hate")
{"text": ["hate"]}
Now
>>> vb.pronunciation("hippopotamus")
[{"rawType": "ahd-legacy", "raw": "hip", "seq": 0}, {"rawType": "arpabet", "raw": "HH IH2 P AH0 P AA1 T AH0 M AH0 S", "seq": 1}]
>>> vb.part_of_speech("hello")
[{"text": "interjection", "example": "greeting", "seq": 0}, {"text": "verb-intransitive", "example": "To call.", "seq": 1}]
>>> vb.antonym("hate")
[{"text": "hate", "seq": 0}, {"text": "dislike", "seq": 1}, {"text": "hater", "seq": 2}]
@tenorz007 Awesome. 👍 Could you update the relevant docs for this? Or should I merge it before?
EDIT: Putting this on the changelog would also be a good idea
I would update the docs first. Does this mean a new release? I was suggesting semantic version which would streamline release changes?
@tenorz007
I would update the docs first.
Cool. Please push the updated docs then. Will merge it.
Does this mean a new release?
Yes, I think this is eligible for a version bump. Updating that too would be one of the agendas of this PR then
I was suggesting semantic version which would streamline release changes?
I thought we were already using semantic versioning weren't we? Point me out if I am mistaken here
@prodicus In a way yes, but ideally it should be of the format major:minor:patch {*} From what I understand:
@tenorz007 Yup. Was under a wrong notion then. Time for our first 1.0.0
then? 😄 What do you think
@prodicus Well if you feel it's stable enough
Fix for #27