Closed tenorz007 closed 7 years ago
@tenorz007 Nothing on the API side as you can see here https://github.com/prodicus/vocabulary/compare/1.0.0...1.0.2
@prodicus So what should be in the changelog then....
@tenorz007 got nothing specific in mind as there wasn't anything specific to the API.
@prodicus That means there's no notable changes to be added to the change log then.....
On Apr 11, 2017 18:01, "Tasdik Rahman" notifications@github.com wrote:
@tenorz007 https://github.com/tenorz007 got nothing specific in mind as there wasn't anything specific to the API.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prodicus/vocabulary/pull/31#issuecomment-293328698, or mute the thread https://github.com/notifications/unsubscribe-auth/AIZg-iIdVszIwlrltFEEONndbO_7m50-ks5ru7HtgaJpZM4M576k .
@tenorz007 yup
@prodicus By the way, I don't think you've been creating releases, just tags.
On Apr 12, 2017 13:14, "Tasdik Rahman" notifications@github.com wrote:
@tenorz007 https://github.com/tenorz007 yup
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prodicus/vocabulary/pull/31#issuecomment-293558037, or mute the thread https://github.com/notifications/unsubscribe-auth/AIZg-vSxRqDSfzdjB_g_DOWcoSJftxRPks5rvMA-gaJpZM4M576k .
Yup. Here is my current workflow.
make all the new changes and commit them to git and then create a tag and push it to github. Is that the wrong way? Correct me if I am wrong here
That wasn't a mistake, I know the version is 1.0.2. However I was putting changelog for the changes I had made when you bumped it up to 1.0.0. As I haven't checked to see what changes you made for the 2 additional patches.