Closed kshitij10496 closed 7 years ago
@kshitij10496
How about we move define the version and release in the setup.py itself so as to keep things condensed ?
As of now, the version and release vars are inside the package vocabulary, this way we are keeping it DRY.
Right now I have made a quick fix in setup.py
here at https://github.com/prodicus/vocabulary/blob/1.0.4/setup.py#L15-L26 for a failing
$ pip install vocabulary --no-cache
Collecting vocabulary
Downloading Vocabulary-1.0.3.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/private/var/folders/sw/nsjcqtxs1yldt7y1gsqkfnw00000gn/T/pip-build-trous1cm/vocabulary/setup.py", line 22, in <module>
with open(path.join(here, 'requirements.txt'), encoding='utf-8') as f:
FileNotFoundError: [Errno 2] No such file or directory: '/private/var/folders/sw/nsjcqtxs1yldt7y1gsqkfnw00000gn/T/pip-build-trous1cm/vocabulary/requirements.txt'
----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/sw/nsjcqtxs1yldt7y1gsqkfnw00000gn/T/pip-build-trous1cm/vocabulary/
Need to create an issue and fix that
On a separate note, I believe that we are using rather constrained dependency package versions. For example, any version of requests above 2.0.0 should work fine as a dependency. What's your take on this?
Please read https://www.kennethreitz.org/essays/a-better-pip-workflow :)
Happy to answer anything else that you have in mind
Hey, I tried to install the package using pip but I'm getting an error. I have added the traceback below:
I wasn't able to install
Vocabulary
in a clean virtual environment (with no installations ofrequests
andmock
) either.As can be observed in the traceback, this issue is due to the import statement in
__init__.py
module which . How about we move define the version and release in thesetup.py
itself so as to keep things condensed ?On a separate note, I believe that we are using rather constrained dependency package versions. For example, any version of
requests
above2.0.0
should work fine as a dependency. What's your take on this?