search

tasgon / observable

See what's lagging your server. 20M+ downloads on CurseForge
https://www.curseforge.com/minecraft/mc-mods/observable
Mozilla Public License 2.0
93 stars 9 forks source link

Crash when try to check Results | 1.18.2 #53

Open 6e3noHToBui opened 1 year ago

6e3noHToBui commented 1 year ago

After profiling, try to seen all results and minecraft closing. Crash log: bruh

tasgon commented 1 year ago

Sounds like a duplicate of #12. From my observations, the issue is fairly infrequent, so it should function when you open the game again. I fixed the issue for 1.19 but didn't backport it to 1.18 yet.

6e3noHToBui commented 1 year ago

Okay, thanks, we'll be waiting it in 1.18

andriihorpenko commented 1 year ago

I can backport a fix to 1.18 if you could mention commit hash with a potential fix.

tasgon commented 1 year ago

The fix was to completely scrap the in-game results window and replace it with the online service at https://o.tas.sh. Technically, the 1.18-online branch should already have most of the changes, but I didn't have enough time then to test and release a new version with the changes.

@andriihorpenko If you're interested in helping, I'd recommend pulling that branch and testing it out to see if it works, then comparing it with the current 1.19 codebase to see if anything else relevant would need to be backported.