search

tashcan / bob

GNU General Public License v3.0
62 stars 15 forks source link

Timeout on trying to claim another box after reveal sequence #19

Open 70B43r opened 8 months ago

70B43r commented 8 months ago

2024-02-12 21_46_22-STFC 2024-02-12 21_46_53-STFC 2 2024-02-12 21_48_46-STFC 3

I'm on Version 0.5.4 and happens since update.

netniV commented 8 months ago

That is a known issue scopely introduced when they add the extra button and did some weird behind the scenes stuff....

tashcan commented 7 months ago

Does it make sense to just remove that entire thing in the patch again, the functionality is in the game now, no? @netniV

netniV commented 7 months ago

It's the skip reveal that would be lost. I love not having to waste time watching that. I just don't use that new button ever, but that's me.

tashcan commented 7 months ago

Wait. Really? I thought the issue was with the stay in bundle code?

netniV commented 7 months ago

No, I tested this and found that only when you turn off Reveal skip does it work as intended by scopely. I also put in debug code to check that the stack of scenes was the same and being replaced and then returned to the same values during an initial call and via the extra button. There was no difference on both ways of collecting.

I have multiple ideas on why, but hitting escape makes it work so my primary one is this suggests there is a scene being dismissed that's not visible, which then makes the rest carry on. So skipping the reveal sequence, maybe a visibility value is being missed and thus causes the issue? Because it's not visible, no transition/timing functions are kicking in?

Note, it doesn't call the doSkipReveal function when the extra button is pressed.

tashcan commented 7 months ago

Great. Scopely not even implementing things correctly according to their internal functions. Fun if someone ever decides to do skipreveal which is a feature in their whole UI thing...bunch of rubbish