tasianmedia / getVimeo

A simple video retrieval Snippet for MODX Revolution
http://modx.com/extras/package/getvimeo
2 stars 5 forks source link

Only 20 videos are handled #10

Closed alfs closed 10 years ago

alfs commented 10 years ago

The vimeo API is limited to 20 videos per "page":

http://developer.vimeo.com/apis/simple

Simple API responses include up to 20 items per page. By adding the ?page parameter to the URL, you can retrieve up to 3 pages of data. If you need more > than the maximum of 60 items, you must use the Advanced API.

Since the getVimeo snippet does not handle this pagination, video 21 and onward are not shown.

I suggest fetching page 1,2,3 and combine them, and issue a log error warning if the max items are reached.

alfs commented 10 years ago

I have created a patch. See pull request https://github.com/tasianmedia/getVimeo/pull/11 .

davidpede commented 10 years ago

Thanks for highlighting this. Have updated the repo and an upgrade package will be released shortly.