tasitlabs / tasit-apps

Native mobile Ethereum dapps for mainstream users
https://tasit.io/
MIT License
36 stars 9 forks source link

Get IPFS hash for an ERC721 token with metadata (and also the hash for the associated image) #129

Open pcowgill opened 5 years ago

pcowgill commented 5 years ago

When this is done, ping Textile with a link to the spot in the app where this happens so they can use that hash to fetch the associated image with their SDK

pcowgill commented 5 years ago

@marcelomorgado The first step here for Decentraland would be seeing what is returned for tokenURI for both land and estates

pcowgill commented 5 years ago

For land they use an npm package called erc821 which is published from the Decentraland repo erc721 (renamed from erc821).

https://github.com/decentraland/erc721/blob/master/contracts/ERC721Metadata.sol

It looks like the name of the function for land may be tokenMetadata rather than tokenURI

marcelomorgado commented 5 years ago

As far as I know, metadata is used to store the name of the assets, but I'll look deep on this.

pcowgill commented 5 years ago

@marcelomorgado It depends on the ERC721, but an arbitrary amount of information can be stored at the token URI if they follow JSON format - name of that particular token, URI for an image, etc.

marcelomorgado commented 5 years ago

Oh, yes. I said about Decentraland assets that I've seen until now.

pcowgill commented 5 years ago

Oh, yes. I've said about Decentraland assets that I've seen until now.

Ah ok, got it

pcowgill commented 5 years ago

This issue is a duplicate to some extent with this issue https://github.com/tasitlabs/tasit/issues/116