search

tasitlabs / tasit-apps

Native mobile Ethereum dapps for mainstream users
https://tasit.io/
MIT License
36 stars 9 forks source link

Detect when the app has been idle for a bit and generate an account only if the user has used the app enough #188

Open pcowgill opened 5 years ago

pcowgill commented 5 years ago

(Or do this as a background task)

pcowgill commented 5 years ago

@marcelomorgado In the long run, I do think we want to detect when the app has been idle for a bit and generate an account only if the user has used the app enough. In the short run, it might show off our simple onboarding flow better if we had this happen behind the scenes while they were browsing land.

If you agree, let's make another issue for that.

Would the account generation step block the user from scrolling on the land screen as it works right now?

marcelomorgado commented 5 years ago

1) To clarify: Should we create a short-term issue to trigger the account set up on the app startup? 2) Not sure, I theory if we wrap the account creation process with an async function it should run in the background. But maybe it'll block the user during the 20segs of generation step (Account.create()), even that happens we can try some trick to solve that.

pcowgill commented 5 years ago

1a. Either that or make it manually triggerable from the My profile screen.

1b. Maybe we decouple account generation and funding too? Open to your creative input here.

1c. I wonder if all of the funding happening behind the scenes sets unreasonable expectations for the "real" flow we'll eventually use. Maybe not if the account is funded with some tokens used to pay for a few meta-tx, anyway. But having MANA may be unrealistic.

  1. Okay yes, let's test specifically this before committing to having this happen on app startup. Triggering it on app startup shouldn't block the loading screen, and if it affects scrolling performance, etc. we wouldn't want to go that route.
marcelomorgado commented 5 years ago

1a. Makes sense; 1b, 1c. Since without expo-crypto, the account generation is spending about 20secs of waiting, sounds good to me decouple these steps and trigger the generation on the startup (if that not impacts the UX performance).

  1. We can make some tryouts on that. As the first step, we can try to move the Account.create() from sign-up flow to start up.

Make sense?

pcowgill commented 5 years ago

1b, 1c. Okay, awesome. FYI on my iPhone X it's a little faster than that.

  1. Okay. yep, let's try a tentative PR with just that change.

Sounds good. Thanks!