search

tasitlabs / tasit-apps

Native mobile Ethereum dapps for mainstream users
https://tasit.io/
MIT License
36 stars 9 forks source link

Introduce hooks api to react-redux #476

Closed pedrobergamini closed 4 years ago

pedrobergamini commented 4 years ago

Issue link

https://github.com/tasitlabs/tasit/issues/441

Auto-close the issue?

Closes #441

Types of changes

Technical debt (a code change that doesn't fix a bug or add a feature but makes something clearer for devs)

Notes

Removes usage of react-redux connect for introducing the hooks API.

I created a GlobalState interface that requires further work for using reducers types

pcowgill commented 4 years ago

@pedrobergamini Thanks so much for working on this!

When you said, "I created a GlobalState interface that requires further work for using reducers types", is that (A) something that would cause problems when running the app now or (B) just something we'd have to keep in mind if we wanted to make further changes ?

pcowgill commented 4 years ago

Oh, was it this TODO you had in mind when saying that? https://github.com/pedrobergamini/tasit/blob/46b3b17a62a96264f022dc6b316cf00abc908b57/decentraland/types/GlobalState.ts#L1

In that case, it's in category (B) above.

pedrobergamini commented 4 years ago

Exactly, it's in category B