TasitAccount main object consisting of both wallet and metatx info

tasitlabs / tasit-sdk

A JavaScript / TypeScript SDK for making native mobile Ethereum dapps using React Native

https://tasit.dev

MIT License

97 stars 10 forks source link

TasitAccount main object consisting of both wallet and metatx info #118

Open marcelomorgado opened 5 years ago

marcelomorgado commented 5 years ago

For now, tasit-account creates a ethers.js wallet object. Should we change that? Could meta-tx support demands more fields to be used here? E.g.:

// TasitAcount.create()
// > Acount { wallet: ..., metaTxInfos..., etc }

Refs: https://github.com/tasitlabs/TasitSDK/pull/71#discussion_r243742850

pcowgill commented 5 years ago

Quoting myself from that thread: "I like this idea! I'll continue to think about the semantics of whether metaTxInfo is part of a "modern" wallet or a distinct concept."