search

tasitlabs / tasit-sdk

A JavaScript / TypeScript SDK for making native mobile Ethereum dapps using React Native
https://tasit.dev
MIT License
97 stars 10 forks source link

TasitAction.Contract decide how is best way to handle with gasLimit #173

Open marcelomorgado opened 5 years ago

marcelomorgado commented 5 years ago

On Decentraland tests I faced gasLimit issues. The first investigation that should be done is why the error printed the revert only instead out of gas error. How users will handle with gas on our API? Should we have some kind of intelligence that will calculate gas needed for the tx and adjust it automatically?

pcowgill commented 5 years ago

On Decentraland tests I faced gasLimit issues. The first investigation that should be done is why the error printed the revert only instead out of gas error.

Yeah, that's surprising. Let's look into this further.

How users will handle with gas on our API? Should we have some kind of intelligence that will calculate gas needed for the tx and adjust it automatically?

Yeah, for sure. And then we can still expose the option to control it manually in a future release. I will research existing solutions for doing this (feel free to look into it too). Thanks!

pcowgill commented 5 years ago

How users will handle with gas on our API? Should we have some kind of intelligence that will calculate gas needed for the tx and adjust it automatically?

Yeah, for sure. And then we can still expose the option to control it manually in a future release. I will research existing solutions for doing this (feel free to look into it too). Thanks!

Let's move this out into a separate issue: https://github.com/tasitlabs/TasitSDK/issues/187