search

tasitlabs / tasit-sdk

A JavaScript / TypeScript SDK for making native mobile Ethereum dapps using React Native
https://tasit.dev
MIT License
97 stars 10 forks source link

GnosisSafe - Improve test cases #235

Open marcelomorgado opened 5 years ago

marcelomorgado commented 5 years ago

Include gas consumption expectations on test cases comparing estimated gas calculated from GnosisSafe contract with gas spent on the transaction. Note: Calculate gas used from sender account balances before and after the transaction.

Refs: https://github.com/tasitlabs/TasitSDK/pull/217#discussion_r260876379

marcelomorgado commented 5 years ago

Another improvement is doing the same assertion as GnosisSafe DailyModule test suite:

Withdrawal should fail because of ERC20 transfer revert Withdrawal should fail because of ERC20 transfer out of gas Withdrawal should fail because of ERC20 transfer returns false