search

taskadapter / redmine-java-api

Redmine Java API
Apache License 2.0
269 stars 162 forks source link

Added issue attribute "is_private" #237

Closed fefurst closed 8 years ago

fefurst commented 8 years ago

According to #236

alexeyOnGitHub commented 8 years ago

I appreciate your support :) can you please address the review comments so that I can review again and merge?

fefurst commented 8 years ago

Sure ....

Felipe Furst

On Sun, Jun 19, 2016 at 2:54 PM, Alexey notifications@github.com wrote:

I appreciate your support :) can you please address the review comments so that I can review again and merge?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/taskadapter/redmine-java-api/pull/237#issuecomment-227010801, or mute the thread https://github.com/notifications/unsubscribe/AP0rWfXWEGhdYYIQAbH49gtuQku3RQTBks5qNYJVgaJpZM4HAYlG .

bcmedeiros commented 8 years ago

I agree that it privateIssue is better than isPrivate, mainly because the getter method would be isIsPrivate(), which is weird.

fefurst commented 8 years ago

Hi ... Got it guys ... as soon as possible I'll change that ...

Felipe Furst

On Fri, Jul 1, 2016 at 5:54 PM, BrunoJCM notifications@github.com wrote:

I agree that it privateIssue is better than isPrivate, mainly because the getter method would be isIsPrivate(), which is weird.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/taskadapter/redmine-java-api/pull/237#issuecomment-230045068, or mute the thread https://github.com/notifications/unsubscribe/AP0rWWR-iIxcAn-XBEDx6gP1IDsdD4vgks5qRX5sgaJpZM4HAYlG .

alexeyOnGitHub commented 8 years ago

this cannot be merged as-is. I added support for parsing this field in https://github.com/taskadapter/redmine-java-api/commit/82b8096cacb8b3c3a01d59144d49e15a57361b2c