search

taskadapter / redmine-java-api

Redmine Java API
Apache License 2.0
269 stars 162 forks source link

Results wrapper #260

Closed albfan closed 8 years ago

albfan commented 8 years ago

Relates to #259

The only thing I dislike is to keep short name for deprecated method: e.g getTimeEntries() vs getTimeEntriesResultsWrapper(). Commits like 682e8a614006753ae809455baa56f1c1d6ff3f6e simply remove old methods getAssignee() with new ones getAssigneeName() and getAssigneeId() but I want to ask before propose a break in compatibility.

Even more I don't know if a single commit is preferred.

I can rebase and squash after code review

alexeyOnGitHub commented 8 years ago

thank you for submitting this. I also appreciate that you take backward compatibility into consideration. let's drop the old methods since this will go to the new major version - 3.0.0 and the compatibility is less of a concern now.

when all done, please squash into 1 commit.

alexeyOnGitHub commented 8 years ago

note - I extracted ResultsWrapper to a separate file in another commit just now.

albfan commented 8 years ago

I have done all fixes, and squashed it. I will fix the conflict with ResultWrapper rebasing it. One second

albfan commented 8 years ago

Done

alexeyOnGitHub commented 8 years ago

super! thank you, @albfan