taskadapter / redmine-java-api

Redmine Java API
Apache License 2.0
270 stars 163 forks source link

Allow setting TargetVersion+Category to null / access names from Memberships #264

Closed matthiasblaesing closed 8 years ago

matthiasblaesing commented 8 years ago

This is the result of moving redminenb to the new major version of redmine-java-api.

Most changes are very smooth and work quite good. These two changesets address two issues:

Please note: The first change was tested by the added unittests, the second set is currently untested, as the testsystem is unresponsive. I ran the second set through manual tests, that showed these change to be working.

Please check if the added unittests for the second part work as expected. Thanks!

alexeyOnGitHub commented 8 years ago

I brought the dev VM with the test Redmine back.

let's use one PR per commit/feature to simplify both review and merge?

matthiasblaesing commented 8 years ago

Thank you for merging this. For you comments: I agree mostly. I had the basics of a followup PR prepared, but I just compared the diffs and while the names of the tests might not match 100%, separating the tests nearly doubles the code - I suggest to keep it this way.

alexeyOnGitHub commented 8 years ago

@matthiasblaesing does the current version work for you? I will release it as 3.0.0 if yes

matthiasblaesing commented 8 years ago

It looks good - my client currently shows some issues I have to tackle before I can think about moving to 3.0.0 fully (not related to the api!), but I checked:

So I would say: I think this is good to go. I really look forward to move back to the master branch! Thank you for your work.

alexeyOnGitHub commented 8 years ago

alright, I will release this as 3.0.0