search

taskadapter / redmine-java-api

Redmine Java API
Apache License 2.0
270 stars 163 forks source link

Add custom fields to TimeEntry #300

Closed christau closed 6 years ago

christau commented 6 years ago

In case you find it useful too.

alexeyOnGitHub commented 6 years ago

how did you test this? I am hesitant to merge any code changes that do not have corresponding tests.

christau commented 6 years ago

I wrote a litte java app for myself, that automatically creates invoices from time entries in redmine. But the time entries in my redmine instance had some cutom fields which i also needed in this java app. Since redmine java api had a clean interface and everything was almost there, i decided to add a few lines for accessing those custom fields. And as it worked for me i thought maybe it's a good idea to have it in the original project, so i don't have to use the custom built jar anymore and others can take advantage of these features from redmine. Long story short. I just don't know how to write a test for this.

alexeyOnGitHub commented 6 years ago

side note - I looked at how custom fields are done for time tracking in Redmine and this just does not make sense to me. I cannot figure out what this is supposed to mean -

alexeyOnGitHub commented 6 years ago

image

alexeyOnGitHub commented 6 years ago

what are these values in custom fields in "Activities" ? and why don't I see custom fields when I click "log time" on an issue?

alexeyOnGitHub commented 6 years ago

I made some changed and merged the end result to "master". let me know if this version works for you

christau commented 6 years ago

Thanks very much for the review and the merge! It works for me.