search

taskadapter / redmine-java-api

Redmine Java API
Apache License 2.0
269 stars 162 forks source link

project add status property #308

Closed LeiXuan6 closed 5 years ago

LeiXuan6 commented 6 years ago

ping , I submitted an update .

alexeyOnGitHub commented 6 years ago

can you please document this change (in javadocs)? what does this status indicate? sample values? also, is there a way to test this change automatically?

LeiXuan6 commented 6 years ago
  1. I have added doc and Test Cases
  2. This status indicates whether the project is closed

Excuse me， The status of Project, redmine written directly in the code?

LeiXuan6 commented 6 years ago

It seems that redmine define the value of the project's status in the code. So I found that the status of the open project is "1" in the database and close is "5". NOTE: My redmine version is 3.1

LeiXuan6 commented 6 years ago

I cannot access the redmine project (https://dev.taskadapter.com/redmine) correctlly even if I use the VPN.

please look here: https://github.com/LeiXuan6/redmine-java-api/blob/master/img/accepnt.png

alexeyOnGitHub commented 6 years ago

I see the reverse proxy is broken at the moment. you can use http://dev.taskadapter.com:8094/ for testing, or just run a Redmine instance locally, e.g.from a Docker image.

LeiXuan6 commented 6 years ago

Could you create a account that has the privilege to manager the project at your redmine server (http://dev.taskadapter.com:8094) for me.

https://github.com/LeiXuan6/redmine-java-api/blob/master/img/error2.png

alexeyOnGitHub commented 6 years ago

I updated the project credentials. the reverse proxy is broken due to Docker-Nginx issues for now.

alexeyOnGitHub commented 6 years ago

status numeric value can depend not only on redmine version, but on a specific db script, language or whatever else. let's not put any version-specific status codes here. the API should just return the numeric value and let user decide what to do with it. maybe their REST API has a way to get all possible project statuses ? that could be used to resolve a specific status name. but overall let's keep it simple: the API will just return the numeric value. some basic tests can be implemented to make sure the value is not empty, etc. nothing version-specific

LeiXuan6 commented 6 years ago

I agree with what you said, thank you for your answer. I modify the source of the project myself, because I need to use the project status.

alexeyOnGitHub commented 5 years ago

this version is now out of date. we can merge another implementation if it works ( https://github.com/taskadapter/redmine-java-api/pull/319 )