search

taskadapter / redmine-java-api

Redmine Java API
Apache License 2.0
269 stars 162 forks source link

bug fix: upload wiki attachments #315

Closed panekzogen closed 5 years ago

panekzogen commented 5 years ago

Continue from issue #314 Problem was not only in renaming json key. Attachments were never sent. RedmineJSONBuilder didn't have any attachments processing.

Added test for JSON object check. Also tested on the real redmine

alexeyOnGitHub commented 5 years ago

is there a way to add an integration test for this change?

panekzogen commented 5 years ago

I has no access to your integration environment. Pull request doesn't run CI as i can see. I can write only some "fish". But you have integration test for attachments reading WikiManagerIT.getSpecificWikiPageByProject() marked as ignored with comment requires manual configuration, see the source code which makes more doubts that test will executed successfully

alexeyOnGitHub commented 5 years ago

I booted up the VM with the dev Redmine server as well as Jenkins for builds in "master" branch. you should be able to run integration tests against that server now.

panekzogen commented 5 years ago

Still cant understand how can i run integration test. Could you please explain what i should do?

alexeyOnGitHub commented 5 years ago

I booted up the dev server again. when you run "gradle build", it will run tests among other things

panekzogen commented 5 years ago

Ok, thank you. I executed my test successfully but one of your tests (com.taskadapter.redmineapi.TimeEntryManagerIT) still cant connect, timeout exception.

NOTE: There is one thing that attachments sends with key uploads but received with key attachments. Seems not healthy but works fine

alexeyOnGitHub commented 5 years ago

@taomWTP thank you fix the bug fix, I pushed the new version to OSS Sonatype, it will be auto-synced to Maven Central soon.

panekzogen commented 5 years ago

@alexeyOnGitHub thank you for fast resolving this problem. Will wait new version