search

taskadapter / redmine-java-api

Redmine Java API
Apache License 2.0
270 stars 163 forks source link

Add getter for project status #319

Closed javiertuya closed 5 years ago

javiertuya commented 5 years ago

There is a related PR #308, that is too old and not merged yet. This PR allows obtaining the STAUS of a project. There are no new tests, instead the status check is added to existing tests.

Note1: Redmine api does not allow reopen, close or archive projects. So as, Project.setStatus has only effect on the project bean, but it does not change the status in the redmine database. An issue was been recorded about this (documented in the code).

Note 2: But we still need setStatus as RedmineJSONParser needs it. A solution to avoid creating this setter could be use storage.set instead result.setStatus, but it is not possible as storage.set is not visible from RedmineJSONParser

alexeyOnGitHub commented 5 years ago

let's remove constants from the code, and document them in Javadoc instead. the rest looks fine

javiertuya commented 5 years ago

Ready to merge