search

taskadapter / redmine-java-api

Redmine Java API
Apache License 2.0
269 stars 162 forks source link

added support for downloading files #358

Closed AdrianDiemerDev closed 3 years ago

AdrianDiemerDev commented 3 years ago

The redmine API allows downloading files which is not implemented in this java client.

I suggest adding this functionality.

alexeyOnGitHub commented 3 years ago

there are no tests for this change. how did you test this? what redmine version?

there is a config for redmine integration tests in the project, although I do not always keep the redmine VM running, so you cannot run them at any time.

it would be best to add a local redmine docker container to run the integration tests against.

AdrianDiemerDev commented 3 years ago

We built an application using this java api and ran it against a redmine 4 docker container.

alexeyOnGitHub commented 3 years ago

would it be possible for you to add the local testing setup using the docker container into this repo? so that people can run integration tests on their computers without having access to my custom VM that is not always online? that would be the best.

there are a few tests that would fail because they require custom setup - see the test comments. Redmine REST API does not support some operations, thus the tests rely on manually created data.

we can ignore those tests and still get useful results from a locally running test container.

AdrianDiemerDev commented 3 years ago

As mentioned in the other thread: I don't feel qualified to do that and I'm not sure it's a good idea anyways.