search

taskcat / taskcat

Apache License 2.0
5 stars 2 forks source link

new config handling #54

Closed jaymccon closed 5 years ago

jaymccon commented 5 years ago

Overview

the Config object has (in it's short life) become a nightmare of indirection and complexity. This aims to fix that by making a BaseConfig that is only concerned with storing the raw config values. And Config that extends that with methods that generate the higher level objects (Template, Test, AWSRegionObject, etc) just-in-time.

This PR also adds some improvements to the e2e tests. Output is now much cleaner, so it's easier to see what went wrong. also added a way to easily run the e2e test container locally, mimicking the behavior in codebuild. ./do-e2e-tests.sh

jaymccon commented 5 years ago

/do-e2e-tests

jaymccon commented 5 years ago

/do-e2e-tests

codecov-io commented 5 years ago

Codecov Report

Merging #54 into master will increase coverage by 2.68%. The diff coverage is 68.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   75.08%   77.77%   +2.68%     
==========================================
  Files          25       24       -1     
  Lines        2665     2254     -411     
  Branches      504      387     -117     
==========================================
- Hits         2001     1753     -248     
+ Misses        539      411     -128     
+ Partials      125       90      -35
Impacted Files Coverage Δ
taskcat/__init__.py 100% <ø> (ø) :arrow_up:
taskcat/_cfn/threaded.py 87.07% <100%> (-0.26%) :arrow_down:
taskcat/_cli_modules/package.py 100% <100%> (+36.36%) :arrow_up:
taskcat/_cli.py 75.55% <100%> (ø) :arrow_up:
taskcat/_cfn/stack.py 90.71% <100%> (+0.83%) :arrow_up:
taskcat/_cli_modules/lint.py 89.47% <100%> (+35.62%) :arrow_up:
taskcat/_cfn/template.py 81.75% <100%> (+0.83%) :arrow_up:
taskcat/_s3_stage.py 50% <14.28%> (+4.54%) :arrow_up:
taskcat/_cli_modules/test.py 37.2% <23.07%> (-8.63%) :arrow_down:
taskcat/_validate.py 42.85% <30%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86346d0...c44abfc. Read the comment docs.

jaymccon commented 5 years ago

/do-e2e-tests

jaymccon commented 5 years ago

/do-e2e-tests