taskcluster / ec2-manager

Mozilla Public License 2.0
2 stars 14 forks source link

spell publishMetaData the jonas way #61

Closed djmitche closed 6 years ago

djmitche commented 6 years ago

It's spelled this way in main.js

jhford commented 6 years ago

This is not a bug. Metadata is a single word, per the Websters and Oxford dictionaries. Per wikipedia:

Camel case (stylized as camelCase or CamelCase; also known as camel caps or more formally as medial capitals) is the practice of writing compound words or phrases such that each word or abbreviation in the middle of the phrase begins with a capital letter, with no intervening spaces or punctuation.

Metadata is not a compounding of words, so it follows that it not have a capital 'd'. If we do anything, it should be to normalise on the correct usage in all of our services.

jhford commented 6 years ago

@djmitche I've pushed a commit to https://github.com/taskcluster/ec2-manager/pull/59 (976d8cb1df81a9f334382718e99d49df5ae86eb7) which uses the correct spelling in lib/main.js. Thanks for finding this, I wonder if it's why we're not getting references being published.